search

ibm-capi / pslse

Power Service Layer Simulation Engine
28 stars 22 forks source link

Plenty of warnings in new version #100

Closed fhaverkamp closed 6 years ago

fhaverkamp commented 6 years ago 
ibcxl.c: In function '_psl_loop':
libcxl.c:1127: warning: unused variable 'op2'
libcxl.c:1127: warning: unused variable 'op1'
libcxl.c:1123: warning: unused variable 'function_code'
libcxl.c:1123: warning: unused variable 'op_size'
libcxl.c: In function '_pslse_connect':
libcxl.c:1499: error: 'PSLSE_VERSION_MAJOR' undeclared (first use in this function)
libcxl.c:1499: error: (Each undeclared identifier is reported only once
libcxl.c:1499: error: for each function it appears in.)
libcxl.c:1500: error: 'PSLSE_VERSION_MINOR' undeclared (first use in this function)
make: *** [libcxl.o] Error 1

would be great if those could get fixed. They might hide real issues.

LanceThompson commented 6 years ago

what branch?

Lance Thompson IBM Technology Development e-mail: lancet@us.ibm.com office: 507.253.0145 mobile: 507.261.3607

From: Frank Haverkamp notifications@github.com To: ibm-capi/pslse pslse@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Date: 12/13/2017 08:26 AM Subject: [ibm-capi/pslse] Plenty of warnings in new version (#100)

ibcxl.c: In function '_psl_loop': libcxl.c:1127: warning: unused variable 'op2' libcxl.c:1127: warning: unused variable 'op1' libcxl.c:1123: warning: unused variable 'function_code' libcxl.c:1123: warning: unused variable 'op_size' libcxl.c: In function '_pslse_connect': libcxl.c:1499: error: 'PSLSE_VERSION_MAJOR' undeclared (first use in this function) libcxl.c:1499: error: (Each undeclared identifier is reported only once libcxl.c:1499: error: for each function it appears in.) libcxl.c:1500: error: 'PSLSE_VERSION_MINOR' undeclared (first use in this function) make: *** [libcxl.o] Error 1

would be great if those could get fixed. They might hide real issues. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

LanceThompson commented 6 years ago

please use tag v3.1 to avoid this issue for the time being.

LanceThompson commented 6 years ago

I have placed a fix for this in the capi2 branch. We still require you to either set PSL8=1 or PSL9=1 for the time being. I'll leave this open until we merge capi2 with master again.

umarajag commented 6 years ago

capi2 branch updated to take in a single environment variable PSLVER PSLVER=8 for psl8 based sims PSLVER=9 for psl9 based sims

fhaverkamp commented 6 years ago

https://github.com/ibm-capi/pslse/issues/98 addresses similar things.