ibm-capi / pslse

Power Service Layer Simulation Engine
28 stars 22 forks source link

Debug messages: Please reduce verbosity #87

Closed fhaverkamp closed 7 years ago

fhaverkamp commented 7 years ago

Hi,

I think that too much data is printed out in default mode. I suggest that this is reduced a bit and made potentially configurable: best at runtime 2nd best compile time.

So this here already reduces the output quite a bit:

diff --git a/afu_driver/src/afu_driver.c b/afu_driver/src/afu_driver.c
index 0eaa5db..59d6da9 100644
--- a/afu_driver/src/afu_driver.c
+++ b/afu_driver/src/afu_driver.c
@@ -672,10 +672,12 @@ void psl_bfm(const svLogic       ha_pclock,               // used as pclock on PLI
          *ha_mmdatapar_top = (event.mmio_wdata_parity) & 0x1;          // 2016/05/11: UMA: checking whether ensuring bval is set always to 0
          *ha_mmcfg_top = event.mmio_afudescaccess;
          *ha_mmval_top = 1;
+#if 0
          printf("%08lld: ", (long long) c_sim_time);
          printf("MMIO rnw=%d dw=%d addr=0x%08x data=0x%016llx\n",
                     event.mmio_read, event.mmio_double, event.mmio_address,
                     (long long)event.mmio_wdata);
+#endif
          cl_mmio = CLOCK_EDGE_DELAY;
          event.mmio_valid = 0;
         }      

Please consider putting this behind e.g. #ifdef DEBUG or alike.

Thanks

Frank

LanceThompson commented 7 years ago

merged fixes from Frank Haverkamp