search

ibm-cloud-architecture / terraform-icp-ibmcloud

This Terraform example configurations uses the IBM Cloud provider to provision virtual machines on IBM Cloud Infrastructure (SoftLayer) and TerraForm Module ICP Deploy to prepare VSIs and deploy IBM Cloud Private on them in Highly Available configuration. This Terraform template automates best practices learned from installing ICP on IBM Cloud Infrastructure.
12 stars 21 forks source link

Update README.md for IBM Cloud File Storage NFS #4

Closed osowski closed 5 years ago

jesusmah commented 5 years ago

Went through the instructions and worked well. However, I would suggest few edits:

  1. In the Create File Storage first section, step 4: Explicitly say the File Storage MUST be on the same data center your ICP cluster will get deployed too. Otherwise you wont have access to it from your ICP boot node.
  2. In the Create Jump Server second section, I believe not all the steps are configured on the first order device dialog. That is, I believe that step 5 and 8 get configured after you clicked place order on the first dialog and you get a second dialog for further configuration of your VM.
  3. In the Copy Tarball third section, step 2 is misleading. That is, when I read I thought I had the binaries in the icp-install folder but there was nothing in there (which makes sense since we are not shipping ICP binaries with the Terraform templates) so people need to find how to download the binaries instead. I would suggest mentioning the XL link in there (https://www-01.ibm.com/software/passportadvantage/)
  4. In the Mount and Copy fourth section, we need the common-nfs library on the system for which we not only should add the apt-get update && apt install -y nfs-common instruction for but also tell readers to give allow_all and allow_outbound permissions on the private security groups back on number 2 above in this comment for calls to ubuntu mirrors to succeed.

I believe this is all I have noted down when ran through the instructions. What do you think?

osowski commented 5 years ago

@jesusmah Pushed updates based on your comments. Please review and let me know.