icp-deploy.tf uses the old vulnerability advisor configuration in disabled management service section

[gangchen03]

The latest configuration for ICP changed the variable to "vulnerability-advisor" This will cause the installation ignore the fact we want to disable vulnerability advisor. Suggest to change icp-deploy.tf line 57 from

    "disabled_management_services"    = [ "${var.va["nodes"] == 0 ? "va" : "" }" ]

To:

    "disabled_management_services"    = [ "${var.va["nodes"] == 0 ? "vulnerability-advisor" : "" }" ]

[jesusmah]

I believe this might be addressed in one of the commits for a pending PR: https://github.com/ibm-cloud-architecture/terraform-icp-vmware/pull/19/commits/f7c78c8d06b4b7f07d16646350e634d5ce3c5f3b

[hassenius]

Fixed by @jesusmah