search

ibm-cloud-architecture / terraform-icp-vmware

Terraform recipe to deploy IBM Cloud Private on VMware
10 stars 15 forks source link

Zero VA nodes fail installation #22

Closed jesusmah closed 5 years ago

jesusmah commented 5 years ago

The vmware terraform cannot build a cluster without a vulnerability advisor node. If you don't have at least one VA node the ansible fails the ICP install with a fatal error. I took a quick look and I think the terraform (actually the generate host file script) doesnt' know how to handle a VA node count of zero and therefore doesn't set the VA off in the ICP hosts file. I suspect this wasn't updated when the VA feature was added to ICP. If you specify at least 1 VA node the build completes

jesusmah commented 5 years ago

I think the problem with this is the way ICP now gets told to either install VA or not. I believe the value we need to pass in the disabled_management_services changed from va to vulnerability-advisor. And I believe it changed from 2.1.0.2 to 2.1.0.3 onwards... Hence https://github.com/ibm-cloud-architecture/terraform-icp-vmware/pull/19/commits/f7c78c8d06b4b7f07d16646350e634d5ce3c5f3b

So if you set VA nodes to 0, which is the way we have to tell ICP we don't want VA, it will append va to the disabled_management_services variable which is not recognised by the installer.

jesusmah commented 5 years ago

From the PR https://github.com/ibm-cloud-architecture/terraform-icp-vmware/pull/31 onwards, VA is defaulted to be disabled so VA nodes can be set to 0 with no problem. If you enable VA but set VA nodes > 0 then it is expected that the installation fails