search

ibm-cloud-architecture / terraform-icp-vmware

Terraform recipe to deploy IBM Cloud Private on VMware
10 stars 15 forks source link

VMware Refactor and new template #31

Closed jesusmah closed 5 years ago

jesusmah commented 5 years ago

Main points in this PR:

  1. Refactor the ICP installation method (also added new section in README to explain this) to be able to install from NFS and private registry (with or without credentials)
  2. Install docker from Ubuntu/RHEL repos if docker_package_location isnt specified (we now expect templates without docker installed.
  3. partition /dev/sdb to be used by docker (Initial problem that triggered the new template creation)
  4. New disable management services strategy where a list with the management services to be disabled is declared.

The template I created for testing terraform VMware is called ubu_1604_31 and can be found on the Templates folder within the vSphere.

jesusmah commented 5 years ago

reminder for @hassenius @fabiogomezdiaz @osowski @gangchen03 @jkwong888 that I need people to review my PR :(

jesusmah commented 5 years ago

@osowski Change done