ibm-cloud-architecture / terraform-openshift4-aws

OpenShift 4 installation automation asset
Apache License 2.0
84 stars 114 forks source link

Remove the infrastructure_id local variable from the main.tf code #2

Closed gangchen03 closed 4 years ago

gangchen03 commented 5 years ago

https://github.com/ibm-cloud-architecture/terraform-openshift4-aws/blob/7fb31aaf1f1af1861acdf8baa80a336bd8393f36/main.tf#L2 Defines a local variable infrastructure_id. This confuses/duplicates with the input variable definition: https://github.com/ibm-cloud-architecture/terraform-openshift4-aws/blob/7fb31aaf1f1af1861acdf8baa80a336bd8393f36/variables.tf#L4

Suggest changing the main.tf code to:

  infrastructure_id = "${var.infrastructure_id}"

or just use ${var.infrastructure_id} when needed