search

ibm-cloud-solutions / hubot-ibmcloud-cognitive-lib

Provides helper functions for configuring, storing, and processing information related to natural language processing of a statement
http://www.ibm.com/
Other
0 stars 0 forks source link

modified tests to use nlcmanager and rrmanager initializer method rat… #101

Closed sam1463 closed 8 years ago

sam1463 commented 8 years ago

…her than setting variables after initialization

coveralls commented 8 years ago

Coverage Status

Changes Unknown when pulling 9363910b04014d49c40b6d2e91db44eb0237c0bc on issues/100 into \ on master**.

jlpadilla commented 8 years ago
  1. To make the code easier to read I'd get rid of the global variable watson_nlc and change init() to return the NLCManager instance return new NLCManager(watson_nlc_options);.
    Then, the tests could be written like init(aaa, bbb).classifierStatus().then(...);.
  2. Give init() a more descriptive name, like initNLCManager().
  3. Same as (1) and (2) for the R&R tests.
coveralls commented 8 years ago

Coverage Status

Changes Unknown when pulling 31c114cc4d07dcd705adf28b825e88fe4dc2eab7 on issues/100 into \ on master**.

jlpadilla commented 8 years ago

👍