Nlc bots addressed in message bug

ibm-cloud-solutions / hubot-ibmcloud-nlc

Adds a framework to enable Natural Language interactions in your Hubot scripts

http://www.ibm.com/

Other

11 stars 1 forks source link

Closed CiaranHannigan closed 8 years ago

CiaranHannigan commented 8 years ago

Added a check to ensure that a bot doesn't pick up on another bot being addressed.

resolves issue #57 resolves issue #58

coveralls commented 8 years ago

Changes Unknown when pulling 3720cba3095a9bfd26c01c88707e184f46959341 on nlc_bots_addressed_in_message_bug into \ on master**.

CiaranHannigan commented 8 years ago

Here is a link with the regex I replicated in that method, https://regex101.com/r/yU5eD6/3

javascript doesn't support lookbehind, so I simulated that by reversing the string and botname and running it with the lookahead.

jlpadilla commented 8 years ago

Discussed some concerns with @CiaranHannigan . Issues #62 and #63 were opened to address these, so I'm merging this change.

jlpadilla commented 8 years ago

👍