search

ibm-cloud-solutions / hubot-ibmcloud-nlc

Adds a framework to enable Natural Language interactions in your Hubot scripts
http://www.ibm.com/
Other
11 stars 1 forks source link

Bot not waiting for entity dialog input #94

Closed jlpadilla closed 8 years ago

jlpadilla commented 8 years ago

In the conversation below, seems like both dialogs listen to the same input.

image

JonHoughton commented 8 years ago

The problem seems to be with the use of Conversations in hubot-ibmcloud-cognitiive-entities. It was creating a new Conversation on each call to getEntities() and using it throughout its processing. But, this doesn't appear to be good enough. After issuing various commands we eventually can get into a state in which the Conversations are confused and use input from another. The fix is to use one Conversation for all processing within an instance of EntityManager.

This required two PRs: https://github.com/ibm-cloud-solutions/hubot-ibmcloud-cognitive-entities/pull/12 https://github.com/ibm-cloud-solutions/hubot-ibmcloud-nlc/pull/95