NLC Integration to add search capability

ibm-cloud-solutions / hubot-ibmcloud-objectstorage

A Hubot script for managing Object Storage containers messages with IBM Object Storage

http://www.ibm.com/

Other

0 stars 0 forks source link

NLC Integration to add search capability #8

Closed kevan-ibm closed 8 years ago

kevan-ibm commented 8 years ago

This PR adds a search capability to the hubot script.

coveralls commented 8 years ago

Coverage increased (+1.1%) to 83.986% when pulling e7eb268c14648a07568366300b5200c7b84c1674 on nlc_integration into d3f0078233248ec6ee5b8a7cdd9fd7a12bb61944 on master.

jlpadilla commented 8 years ago

NLCHelper.js belongs in hubot-ibmcloud-cognitive-lib. The code is too similar to what's already in cognitive-lib. I'd prefer to re-write cognitive-lib as a more general purpose library capable of handling the cases needed here.

coveralls commented 8 years ago

Coverage increased (+1.9%) to 84.699% when pulling fa545d13f94bf89a1ffa0b0cfedb8964842cc58b on nlc_integration into d3f0078233248ec6ee5b8a7cdd9fd7a12bb61944 on master.

coveralls commented 8 years ago

Coverage increased (+1.9%) to 84.699% when pulling d595a64816b3eb72d693530a404f65f9685ebee5 on nlc_integration into d3f0078233248ec6ee5b8a7cdd9fd7a12bb61944 on master.