search

ibm-cloud-solutions / hubot-ibmcloud-service-suggest

A hubot script for providing assistance to a user who needs help finding Bluemix service(s) that match his needs.
http://www.ibm.com/
Other
2 stars 0 forks source link

Include accented characters and training data update, Closes #1 #16

Closed reicruz closed 8 years ago

reicruz commented 8 years ago

IoT Real-Time Insights, Mobile Data, Push were removed from the catalog.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 80.526% when pulling 4a2de867716cc7af1f76e7ff836599dfcac87482 on issues/1 into 7f2a545abdab4d303ac7e6c6a90f92390be30681 on master.

kurtismgit commented 8 years ago

@reicruz your change regarding the regular expression makes things better, so I'm going to go ahead and merge. But soon we should do away with stripSpecial() all together to consider the comment @todkap about allowing all unicode characters. I'll create a separate issue for that soon.

Also, I had to fix our test as part of this PR. Our tests mock data have the filename in the nlc responses. So I had to change the version # in the test. I'm sure you would have caught that if not for the nlc dependency issue that previously blocked our test from running.

reicruz commented 8 years ago

@kurtismgit good catch on the tests! thanks for the fix