Closed tworkman512 closed 6 years ago
Sorry one last comment, can you delete the package-lock.json
file and create a yarn.lock
file instead? We're going to be using yarn
for this project.
@diego-codes made the requested changes and ready for review.
What kind of change does this PR introduce?
carbon-components-react
,carbon-components
, andcarbon-icons
as dependencies.tile
Carbon react component in the About page.carbon-component
global styles.Did you write unit test?
No, I'm not sure how to do that and could use some help if that's necessary here.
Summary
Carbon React components and styles must be imported to be used in creating a Gatsby site. See issue here for more context: https://github.com/ibm-frontend/gatsby-starter-carbon/issues/6
Other information
Please note, that I chose to import the
tile
Carbon styling directly here temporarily until we add the global styling for Carbon.Also, I'm not 100% certain that I added the Carbon global styles correctly and would appreciate someone checking that and offering any guidance if needed. I didn't remove the Material Design styling yet, as that would break pretty much every style in the UI at this point.