search

ibm-functions / package-cloud-object-storage

Deploy a Cloud Object Storage Package for IBM Functions.
Apache License 2.0
2 stars 9 forks source link

Should actions be in their own folder? #23

Closed bvennam closed 6 years ago

bvennam commented 6 years ago

Currently, we have actions living alongside the manifest file describing what's inside the package. I think it is cleaner to put all the actions in an actions folder, especially if there are quite a few. We do this for other templates, even though most of those templates have very few actions. https://github.com/ibm-functions/template-cloud-object-storage/tree/master/runtimes/nodejs https://github.com/ibm-functions/template-get-external-resource/tree/master/runtimes/nodejs

runtimes
    nodejs
        manifest.yaml
        actions
            action1
            action2
eweiter commented 6 years ago

I think it would be cleaner to have them in their own folder. @csantanapr You want to weigh in? I'll make the change soon if I don't hear from you.

csantanapr commented 6 years ago

Ah cool good improvement Didn’t notice. Good to have manifest by itself and all actions in the actions directory.

csantanapr commented 6 years ago

Belinda I thought it followed the other templates format already

csantanapr commented 6 years ago

Good catch

bvennam commented 6 years ago

merged June 11th.