search

ibm-genwqe / genwqe-user

The project uses a PCIe-Card for FPGA based zlib acceleration. This project provides a hardware accelerated version of zLib based compression/decompression RFC1950/RFC1951/RFC1952 with help of an FPGA based PCIe card.
Apache License 2.0
17 stars 15 forks source link

Change lib files location and usage of pthread #140

Open ferseiti opened 7 years ago

ferseiti commented 7 years ago

Hello. Could you please consider these 2 points:

1 - Since libzADC.so* are exclusive to genwqe-user, why not install directly into $(DESTDIR)/lib64, then put libz.so and libz.so.1 link into subdir genwqe, like so: /usr/lib64/ ├── genwqe │   ├── gunzip -> ../../../bin/genwqe_gunzip │   ├── gzip -> ../../../bin/genwqe_gzip │   ├── libz.a -> ../libzADC.a │   ├── libz.so -> libz.so.1 │   └── libz.so.1 -> ../libzADC.so.4.0.18 ├── libzADC.a ├── libzADC.so -> libzADC.so.4.0.18 ├── libzADC.so.4 -> libzADC.so.4.0.18 └── libzADC.so.4.0.18

  1. Using -lpthread will only link against the pthread library. Can we use the more complete -pthread instead?

Thanks!

fhaverkamp commented 7 years ago

Sounds good to me, do you have some patches which do this?