ibm-granite-community / granite-snack-cookbook

Granite Snack Cookbook -- easily consumable recipes (python notebooks) that showcase the capabilities of the Granite models
Creative Commons Attribution 4.0 International
73 stars 17 forks source link

GG: CI added #39

Closed ink-pad closed 1 month ago

ink-pad commented 1 month ago

PR Checklist

adampingel commented 1 month ago

@ink-pad Looks like your commit needs a sign-off https://github.com/ibm-granite-community/granite-snack-cookbook/pull/39/commits/bc6b84d814e11034542f58dfe7462ecf91e3c1ef

adampingel commented 1 month ago

If the calls to torch.no_grad are meant to be an optimization for testing, let's check this environment variable and only apply that optimization only when this variable is present with this value:

image

ink-pad commented 1 month ago

@adampingel : Thanks for the comment, Adam. No - it is not specific to testing alone. We want this to be default behavior for any inference.