Open manojjahgirdar opened 2 weeks ago
The ci build failed with an import error. I think you may be miss installing a needed package.
Ok let me fix the import statements
Hi @bjhargrave, I have fixed the import statement, how do I trigger the CI builds?
It failed again, this time it says WATSONX_URL
not found. If you see I have defined it correctly in the notebook.
Testing Notebooks workflow launched on this PR: View run
pull_request
workflows do not have access to the secrets. I started a workflow which does.
@bjhargrave can you rerun the CI pipeline now?
Testing Notebooks workflow launched on this PR: View run
@bjhargrave can you rerun the CI pipeline now?
Testing Notebooks workflow launched on this PR: View run
In looking at the code in the notebook, it does not seem to use the Granite 3 prompts for tool use: https://www.ibm.com/granite/docs/models/granite/#tool-usefunction-calling-weather-scenario
It just looks like vanilla langchain tool use.
I just referred to the https://github.com/ibm-granite-community/granite-snack-cookbook/blob/main/recipes/AI-Agents/Agentic_RAG.ipynb recipe and tried to solve this new use case. I will try to change the prompt if that is absolutely required.
Changing the prompt may not give desired output, I can still give it a try.
Understood. I am just trying to see if we should, in these Granite recipes, exploit the Granite prompt architecture for things like tool calling. @adampingel Do you have an opinion here? I know that many of the extant recipes were written before Granite 3 was released. But I would think that as we add new recipes, we should lean in to the Granite prompt architecture.
BTW, I have hacked on the existing Function_Calling snack to use the Granite prompt tool calling. I can make a PR for that update soon.
Hi @bjhargrave, I have updated the prompt to use granite 3.0 prompt for tool calling. Can you rerun the pipeline to test it? Thanks.
You also need to run the pre-commit hooks to clean up the notebook. There is also a readme conflict to resolve.
Testing Notebooks workflow launched on this PR: View run
Ran the pre-commit hook and resolved the readme conflict. Can you run the pipeline once again?
Testing Notebooks workflow launched on this PR: View run
PR Checklist
Model Interaction
Data
Notebook requirements
!pip install git+https://github.com/ibm-granite-community/utils
in the first code cell in order to makeget_env_var
available to accessing secrets and variables in the recipe.Incoming References
GitHub