search

ibm-granite-community / pm

Granite Community Project Management
0 stars 0 forks source link

Test each notebook with a new Virtual Env #156

Closed fayvor closed 3 weeks ago

fayvor commented 1 month ago

Modify CI workflow in these cookbooks:

Also: strip the Python version from the notebook?

fayvor commented 4 weeks ago

Kitchen PR Snacks PR Code PR Legal PR Timeseries PR Finance PR

All Merged.

adampingel commented 4 weeks ago

From the comments on the PRs:

@deanwampler suggests doing this comment filtering consistently:

notebooks=$(cat .github/notebook_lists/vanilla_notebooks.txt | grep -v '^#' | tr '\n' ' ')

@rawkintrevo suggests weighing the pros and cons of 1 workflow per notebook.

Let's file an issue for the former and discuss the latter before we close this ticket. Both otherwise I will merge the PRs.

bjhargrave commented 4 weeks ago

I can help with GitHub Actions workflows. I have a bunch of experience. I would recommend one job per notebook using a matrix so they share a single workflow.

See https://github.com/instructlab/instructlab/blob/4780b8dc6e284d95c5af2b3fd120a9deffeb5fc2/.github/workflows/lint.yml#L43-L97 for one I did.

deanwampler commented 4 weeks ago

From the comments on the PRs:

@deanwampler suggests doing this comment filtering consistently:

notebooks=$(cat .github/notebook_lists/vanilla_notebooks.txt | grep -v '^#' | tr '\n' ' ')

@rawkintrevo suggests weighing the pros and cons of 1 workflow per notebook.

Let's file an issue for the former and discuss the latter before we close this ticket. Both otherwise I will merge the PRs.

I created https://github.com/ibm-granite-community/pm/issues/157 to add the | grep -v '^#' and also set -e. Most of the repos already have PRs. I'll create PRs for the remaining two cited in the issue later today.

rawkintrevo commented 4 weeks ago

I agree with @bjhargrave . I remember the matrices from travis, i didn't know how to do it in ghactions. @bjhargrave can you join the standup tomorrow to guide @adampingel and @fayvor ?

bjhargrave commented 4 weeks ago

can you join the standup tomorrow

Sure, I will need to added to the invite.

fayvor commented 3 weeks ago

The benefit I see of using a matrix would be to parallelize the test runs. If we go the direction of one workflow per notebook, we should try and get the workflows running in parallel.