search

ibm-js / delite

HTML Custom Element / Widget infrastructure
http://ibm-js.github.io/delite/
Other
68 stars 28 forks source link

What dojo repo are you using? #17

Closed lbod closed 11 years ago

lbod commented 11 years ago

I see 1.9.0dev in the package but suspect that's old docs? It doesn't seem to be https://github.com/csnover/dojo2-core.git as some tests are using _base Almost got it working but require.js is in one of the tests so had to pull it manually.

Is it worth updating package.json with the correct deps?

wkeese commented 11 years ago

I'm using https://github.com/wkeese/dojo/tree/nodep (note that it's a different branch, not the master branch).

It would be good to update package.json to list that but I'm not sure how. Package.json should also point to dcl version 1.1.

Another possible fix is to put requirejs at the top level, as a sibling of dojo and dui, and update tests/boilerplate.js to point to that. Probably the loader shouldn't be part of dojo/.

cjolif commented 11 years ago

I think indeed it would be better to have requirejs as a sibling just for the other dependencies, there is no reason to treat it differently (except of course if Dojo 2.0 adopts requireJS in its core in 2.0 but that does not seem to be the current direction).

cjolif commented 11 years ago

I have updated package.json & added a bower.json in 8d6f80f1adcd19c77ffbecf5fc5bf3310672c1a8 . Note that more dependencies might be added over time or versions we depend on change. Bill is using his branch for dojo but I'm using regular dojo repo without issues so I think you can keep that as well.

lbod commented 11 years ago

Much appreciated, thank you

wkeese commented 11 years ago

OK, I'll update boilerplate.js to expect requirejs as a sibling (rather than a child) of dojo.