KeyNav: give access to the original event in keynav-child-navigated event. Fixes #371

ibm-js / delite

HTML Custom Element / Widget infrastructure

http://ibm-js.github.io/delite/

Other

68 stars 28 forks source link

KeyNav: give access to the original event in keynav-child-navigated event. Fixes #371 #372

Closed AdrianVasiliu closed 9 years ago

AdrianVasiliu commented 9 years ago

See #371

I did not check yet if further updates would be needed to doc and tests - to avoid loosing time for nothing in case you don't like the idea @wkeese. But I can add that if you buy it.

If this change is done in delite, deliteful/list/List would follow accordingly: https://github.com/AdrianVasiliu/deliteful/commit/5511a9ec79713adb862cda5597bb47ce85b41cbb.

wkeese commented 9 years ago

Makes sense. I pushed your change. But I suppose you need another tag on delite to be able to use this in deliteful? Let's do that when we update the dependency on requirejs-dplugins.

AdrianVasiliu commented 9 years ago

Great, thanks @wkeese. Yes, re-releasing delite would be needed to be able to rely on it in deliteful (merging the List counterpart - https://github.com/ibm-js/deliteful/pull/483 - and the use for Combobox keyboard navigation will wait for it). Sorry, my PR came just after you released delite.