search

ibm-js / delite

HTML Custom Element / Widget infrastructure
http://ibm-js.github.io/delite/
Other
68 stars 28 forks source link

delite/KeyNav: misbehavior when focusDescendants is set to false after initialization #375

Closed AdrianVasiliu closed 9 years ago

AdrianVasiliu commented 9 years ago

In its postRender(), KeyNav installs event handlers for "delite-deactivated" and "focusin" conditionally, only if focusDescendants is true (default value), and these handlers are NOT removed if focusDescendants is later set to false (while the doc doesn't say it should not be changed after initialization, and in Combobox case it can only be changed after List's initialization).

I think KeyNav.refreshRendering() should take care of installing/uninstalling these handlers depending on the current value of focusDescendants. Alternatively (but less optimal I guess), the handlers could be made no-op when this.focusDescendants is false.

AdrianVasiliu commented 9 years ago

Submitted #376 for it.

cjolif commented 9 years ago

please put 0.6.0 milestones and type of (bug, enhancement...) on issues so that they appear automatically in "release notes".

AdrianVasiliu commented 9 years ago

Thanks @wkeese. @cjolif: done.

AdrianVasiliu commented 9 years ago

@wkeese could you please re-release delite with a beta tag (0.6.0-beta.4)?

wkeese commented 9 years ago

OK, I did.