ibm-js / delite

HTML Custom Element / Widget infrastructure
http://ibm-js.github.io/delite/
Other
68 stars 28 forks source link

delite/popup.open() doesn't call onExecute() when popup emits change/execute event #429

Closed wkeese closed 9 years ago

wkeese commented 9 years ago

Code like this is supposed to call the onExecute() method when the popup widget fires an "execute" or "change" event:

this._openRet = popupUtil.open({
    popup: popup,
    ...
    onCancel: function () {
        console.log(id + ": cancel of child " + popup.id);
    },
    onExecute: function () {
        console.log(id + ": execute of child " + popup.id);
        popupUtil.close(popup);
    }
}); 

It's working for onCancel() but not onExecute().

There's also some code in the delite/popup code for dealing with nested popups, specifically menus, that we aren't using, and can be removed.