ibm-js / delite

HTML Custom Element / Widget infrastructure
http://ibm-js.github.io/delite/
Other
68 stars 28 forks source link

support popups with internal scrollbars #472

Closed wkeese closed 7 years ago

wkeese commented 7 years ago

When a popup's height is reduced so that it fits in the viewport, the scrollbar used to be put on the popup wrapper. However, this isn't useful for deliteful/TooltipDialog, because the scrollbar should be on the TooltipDialog#containerNode.

Historically the scrollbar was put on the wrapper to support popups like dropdown menus that were <table> nodes, but that's not very important anymore thanks to flexbox sizing.

Therefore, modify delite/HasDropDown and delite/popup to set the size on the popup itself.

Eventually this should also lead the way to getting rid of the wrapper completely.