ibm-js / delite

HTML Custom Element / Widget infrastructure
http://ibm-js.github.io/delite/
Other
68 stars 28 forks source link

Tests are sometimes failing on FF ESR 24.2 (but working on FF ESR 24.1 or Chrome) #84

Closed cjolif closed 5 years ago

cjolif commented 10 years ago

hmm actually I don't reproduce only @sbrunot has that. I do have an error so I thought it was the same one him. But on FF ESR 24.1 the error I have is on a11y:

[16:59:11.387] "Error: a11y.getFirstInTabbingOrder(...) is undefined
.findTabElements@http://localhost/Dojo2/delite/tests/a11y.js:43
Test.prototype.run@http://localhost/Dojo2/delite/node_modules/intern//lib/Test.js:154
runNextTest/</<@http://localhost/Dojo2/delite/node_modules/intern//lib/Suite.js:210
signalListener@http://localhost/Dojo2/delite/node_modules/intern//node_modules/dojo/Deferred.js:37
Deferred/promise.then@http://localhost/Dojo2/delite/node_modules/intern//node_modules/dojo/Deferred.js:258
runNextTest/<@http://localhost/Dojo2/delite/node_modules/intern//lib/Suite.js:214
"

and even that one happens sometimes not always (like a timing issue?)

wkeese commented 10 years ago

I've seen those timing issues but haven't had a chance to track them down. :-(

wkeese commented 10 years ago

There was a problem with a bad image path causing that problem, making the <img> node 0x0 instead of 16x16. Maybe there was also a race condition with the test running before/after the image failed to load. I fixed both of those problems in 81928673badb14cef42869edace08ebc836ce7e9 and 31aba09bf04e4f27b05b1b539b9da227c6222329.

Are you still seeing the failure? For some reason I can't run the firefox tests against saucelabs at all, but I'm not seeing the failure when running locally.

sbrunot commented 10 years ago

It's ok on my laptop too (not using saucelabs). Unrelated, but some delite/Store and delite/StoreMap tests are failing.

cjolif commented 10 years ago

I still get it:

[10:37:17.803] "Error: a11y.getFirstInTabbingOrder(...) is undefined
.findTabElements@http://localhost/Dojo2/delite/tests/a11y.js:43
Test.prototype.run@http://localhost/Dojo2/delite/node_modules/intern//lib/Test.js:154
runNextTest/</<@http://localhost/Dojo2/delite/node_modules/intern//lib/Suite.js:210
signalListener@http://localhost/Dojo2/delite/node_modules/intern//node_modules/dojo/Deferred.js:37
Deferred/promise.then@http://localhost/Dojo2/delite/node_modules/intern//node_modules/dojo/Deferred.js:258
runNextTest/<@http://localhost/Dojo2/delite/node_modules/intern//lib/Suite.js:214
"

less often maybe but still.

cjolif commented 10 years ago

@wkeese are you using FF 24.2? (maybe you are using another version?)

wkeese commented 10 years ago

I tested repeatedly on both FF26/mac and FF24.2/mac (downloaded from http://www.mozilla.org/en-US/firefox/organizations/all.html). I don't see the error anymore.

Note that Saucelabs supports 24.0 but not 24.2.

sbrunot commented 10 years ago

Everything is fine on my side now.

cjolif commented 10 years ago

still reproducing on FF ESR31.1

wkeese commented 10 years ago

OK... and it fails when run from the browser for just that one test, http://localhost/delite/node_modules/intern/client.html?config=tests/intern&suites=delite/tests/unit/a11y (or whatever your URL is)?

This is from the <area-map> node. It's such an obscure case, I guess I could just remove it from the test file.

Or alternately you can try debugging on your side, perhaps adding a small delay after setting innerHTML but before the real tests run. Unfortunately I can't debug it since it runs for me.

cjolif commented 9 years ago

OK... and it fails when run from the browser for just that one test,

Yes it does fail with the single test url.

Or alternately you can try debugging on your side, perhaps adding a small delay after setting innerHTML but before the real tests run. Unfortunately I can't debug it since it runs for me.

I guess this is not high priority as I'm the only one facing this apparently ;) I'll try to look at it when I will get some more time...

wkeese commented 5 years ago

Closing since it's about an obsolete version of Firefox. I think the tests are working fine on the newest Firefox.