search

ibm-js / deliteful

Multichannel (desktop/mobile) UI Custom Elements Library
http://ibm-js.github.io/deliteful
Other
70 stars 36 forks source link

[regression] List: doesn't remember last focused ListItem #680

Closed wkeese closed 7 years ago

wkeese commented 7 years ago

Tab into a List, arrow down to a different ListItem, tab out of the List and then shift-tab back in. You end up on the first ListItem rather than the previously focused one.

Presumably focus used to return to the previously focused ListItem because List.js has code to do that in List#_keynavDeactivatedHandler(). But that method is no longer called after ibm-js/delite@3b7c96f074e898269f6a08f23c45c5c3329189b8. List shouldn't have been depending on a private function anyway.

I think we are also missing a test case for this.

Refs ibm-js/delite#462.

wkeese commented 7 years ago

Actually, there is a test already, the "keyboard navigation with default renderers" test is failing without this fix, since the Shift-TAB goes to "Programmatic item of order 0" rather than "Programmatic item of order 1".