search

ibm-js / ecma402

ECMA-402 JavaScript Internationalization API "shim"
Other
34 stars 21 forks source link

Some minor problems with README.md #54

Closed JCEmmons closed 10 years ago

JCEmmons commented 10 years ago

The README.md doc should have a couple of changes made:

1). The link to MDN should point to the English version, not the French version. 2). It should also mention that if you want to force the IBM implementation, you can just require ecma402/Intl instead of ecma402/IntlShim, instead of having to set

config: { "requirejs-dplugins/has": { "intl-api": false }

cjolif commented 10 years ago

For 1), yes obviously, at least until French take over again ;)

For 2) I found the current recommended solution cleaner, this allows to keep the application code as-is and switch from one to another in a central place instead of modifying each of the source files using ecma402. Obviously your solution working as well, so maybe it can still be mentioned but I think we should also keep what is here now.

JCEmmons commented 10 years ago

Yes, for 2). not planning on removing anything, just adding to what is already there.