Closed wkeese closed 10 years ago
From looking at the code and tracing in the debugger, IntlShim.js always loads Intl.js, whereas the goal is to only load it conditionally.
IntlShim.js has this code:
define(["./features!intl-api?:./Intl"]
as though features were a plugin. But it is not.
features
Also, there is no test file that just loads IntlShim.js, which makes it hard to see whether or not Intl.js is getting loaded unnecessarily or not.
It is working for me. I tested it by replacing ecma402/Intl by ecma402/IntlShim. Also, features is a plugin as it is just a wrapper for requirejs-dplugins/has.
ecma402/Intl
ecma402/IntlShim
requirejs-dplugins/has
Oh, I got confused, OK nevermind.
From looking at the code and tracing in the debugger, IntlShim.js always loads Intl.js, whereas the goal is to only load it conditionally.
IntlShim.js has this code:
as though
features
were a plugin. But it is not.Also, there is no test file that just loads IntlShim.js, which makes it hard to see whether or not Intl.js is getting loaded unnecessarily or not.