search

ibm-js / ecma402

ECMA-402 JavaScript Internationalization API "shim"
Other
34 stars 21 forks source link

IntlShim.js always loads Intl.js #58

Closed wkeese closed 10 years ago

wkeese commented 10 years ago

From looking at the code and tracing in the debugger, IntlShim.js always loads Intl.js, whereas the goal is to only load it conditionally.

IntlShim.js has this code:

define(["./features!intl-api?:./Intl"]

as though features were a plugin. But it is not.

Also, there is no test file that just loads IntlShim.js, which makes it hard to see whether or not Intl.js is getting loaded unnecessarily or not.

clmath commented 10 years ago

It is working for me. I tested it by replacing ecma402/Intl by ecma402/IntlShim. Also, features is a plugin as it is just a wrapper for requirejs-dplugins/has.

wkeese commented 10 years ago

Oh, I got confused, OK nevermind.