set has() flags from dojo/core

ibm-js / requirejs-dplugins

AMD plugins for RequireJS

http://ibm-js.github.io/requirejs-dplugins/

Other

6 stars 9 forks source link

set has() flags from dojo/core #1

Closed wkeese closed 10 years ago

wkeese commented 10 years ago

In order for delite and deliteful to start using requirejs-dplugins/has instead of dojo/has, we'll need the definition of certain has() flags that dojo/core defined:

host-browser (used by delite/sniff)
dom (not used, but probably should be used by delite/register)
touch (hmm, maybe this isn't used anywhere, but it's a basic flag)
touch-events (used by delite/focus)
pointer-events (used by delite/focus)
MSPointer (used by delite/focus)

You could change the names if you want, but they need to be defined somewhere, and this project seems like a good place?

PS: See ibm-js/sdk#8.

asudoh commented 10 years ago

Probably it's sdk-core/sniff thing? CC @cjolif

cjolif commented 10 years ago

@wkeese those looks more like features detection than browser sniffing, right? Then per one of your previous suggestions the module should be called features not sniff?

And ideally I guess both sniff & features should end up in the "core" package to keep the plugin package "pure" plugin. At least it seems to me sniff & features have no reason to be in different packages?

wkeese commented 10 years ago

I see your arguments. I just thought it would be simpler to have everything in a single module rather than having multiple modules across multiple packages.

If I were designing it I would probably put all the code in one place (has, feature detection, and browser sniffing), but sounds like you guys want to separate it across two packages. Either way is possible. Since you are talking about "purity" I can see it's a philosophical thing.

cjolif commented 10 years ago

I propose to close this except, we can always revisit it later if needed.