search

ibm-js / requirejs-dplugins

AMD plugins for RequireJS
http://ibm-js.github.io/requirejs-dplugins/
Other
6 stars 9 forks source link

use jquery promises #11

Closed cjolif closed 9 years ago

wkeese commented 9 years ago

I see that @clmath pushed this immediately. It would have been better to give it some time for discussion as switching to jQuery promises is a big change.

Having said that, the change seems fine for requirejs-dplugins since its use of promises is isolated.

You should also though remove the following paragraph from the jQuery plugin doc, since (as I predicted might happen) it's no longer true:

When using this plugin, you must manually include jquery into your app via bower install jquery or via a script tag (ex: <script src="https://code.jquery.com/jquery-2.1.1.min.js">).

clmath commented 9 years ago

I see that @clmath pushed this immediately. It would have been better to give it some time for discussion as switching to jQuery promises is a big change.

Having said that, the change seems fine for requirejs-dplugins since its use of promises is isolated.

I agree it was fast but there was pressure from users to remove the dojo dependency. Also as you said the changes are small and localized so it would not be hard to revert in the future if needed.

I will indeed update the jquery plugin doc.