search

ibm-js / requirejs-dplugins

AMD plugins for RequireJS
http://ibm-js.github.io/requirejs-dplugins/
Other
6 stars 9 forks source link

Remove requirejs-dplugins/css.js dojo dependency #4

Closed pruzand closed 9 years ago

pruzand commented 9 years ago

Today the requirejs-dplugins/css plugin depends on dojo/Deferred. While it was not a real issue when the plugin was part of the delite project, this dependency is more critical now that it has been moved to requirejs-dplugins. Indeed, if a project depends on it, it will bring all dojo with it. This is the case if a project depends on ecma402 for example: in this case you end up with a dependency on dojo even if you don't use it, just because the requirejs-dplugins/css requires Deferred. IMO it would be great if the css plugin would depend on another promises implementation.

cjolif commented 9 years ago

see ibm-js/sdk#5

clmath commented 9 years ago

This is fixed in https://github.com/ibm-js/requirejs-dplugins/commit/0714c2c408c929627cb0a5492526887b65f71e11