search

ibm-js / requirejs-dplugins

AMD plugins for RequireJS
http://ibm-js.github.io/requirejs-dplugins/
Other
6 stars 9 forks source link

Jquery plugin #8

Closed wkeese closed 9 years ago

wkeese commented 9 years ago

Jquery plugin.

Since jquery's model is that every module adds functionality to the $ symbol (i.e. the variable returned by the jquery/core module), I opted to allow listing multiple modules for the plugin, ex:

require(["requirejs-dplugins/jquery!attributes/classes,effects"], function ($){
    ...
    $(myNode).addClass("selected");
    $(myNode).animate(...);
});

Other things to note:

jQuery code is in jquery/src dir by default, so plugin is mapping to that directory automatically. Seems a bit weird.

This PR also includes some other enhancements:

  1. standardizing the test directories into unit/ and functional/ (like other projects)
  2. upgrade to intern 2.1

TODO: automate build test (webdriver load app.html and check output)

cjolif commented 9 years ago

I'm ready to handle that and I think that with a clear user documention most of those tickets can be avoided.

Ok, then I think the modification should be done, we should merge and that way we can tag a delite beta so that I can update deliteful for dstore 1.0 ;)

wkeese commented 9 years ago

Pushed as 975477fba345c80fb87acad5356280655cd8ab9c.