search

ibm-mas / ansible-devops

Ansible collection supporting devops for IBM Maximo Application Suite
https://ibm-mas.github.io/ansible-devops/
Eclipse Public License 2.0
49 stars 82 forks source link

[major] Delete all CertManager CRDs with cert-manager uninstall #1262

Closed andrercm closed 5 months ago

andrercm commented 5 months ago

This PR addresses problems found in https://github.com/ibm-mas/cli/issues/868

It is all about including Certificate Manager CRD to be deleted in cert_manager role during uninstall action. Without that, during common services reinstall, ibm common services operator will lookup Certificate CRD and will find it and think certmanager is installed and call cert manager webhook pod (which is not present because it was deleted during certmanager uninstall) and then fail to proceed with ibm-common-services reinstall...

Tests done:

image

CertManager CRDs before uninstall:

image

All Certmanager CRDs are gone:

image

Then, re-running mas install command after a mas uninstall allows reinstalling ibm common services and cert-manager just fine:

image
whitfiea commented 5 months ago

Changed this to major as it changes the behaviour and could cause issues for users that are expecting the old behaviour of the CRDs to be left.