ibm-mas / ansible-devops

Ansible collection supporting devops for IBM Maximo Application Suite
https://ibm-mas.github.io/ansible-devops/
Eclipse Public License 2.0
49 stars 86 forks source link

cp4d role should check that the correct version of foundational service is installed. #704

Closed mattlrx closed 1 year ago

mattlrx commented 1 year ago

issue: When installing a version other than the latest version of MAS, we need to add the version of the supported dependency, for instance, installing MAS 8.7, oneclick_core installs the latest version of cp4d (cloudpak for data) and cpfs (cloudpak foundationnal service) unless you specify the environment variable COMMON_SERVICES_CHANNEL

therefore, the ask would be:

andrercm commented 1 year ago

Hello @mattlrx , thank you for your feedback.

Can you please inform what's the current problem you are experiencing? That will help us assess the impact of it so we can prioritize accordingly.

I think what you are proposing is a valid enhancement. We want to avoid adding extra logic to automatically manage versions cross different dependencies to make them compatible with each other, because it might become pretty hard for us to maintain our code for the future if we go down that path, however I believe there's a way to check and assert if we're installing a CPD version that is compatible with the current installed version of IBM Common Services / Foundation Services, (this information is already available as part of a configmap that we use to install CPD) and that might be enough to ensure we're keeping both Common Services, as a prereq, and CPD versions aligned and compatible.

andrercm commented 1 year ago

Running tests for this issue... this is the preview message users will receive if running incompatible Foundation/Common Services version vs CPD expected one:


TASK [ibm.mas_devops.cp4d : Assert that ibm-common-services is installed and is compatible with CPD version 4.6.4] *****************************************
fatal: [localhost]: FAILED! => {
    "assertion": "foundation_services_installed_csv_version is version_compare(foundation_services_csv_version, '>=')",
    "changed": false,
    "evaluated_to": false,
    "msg": "Failed! You have incompatible IBM Foundation Services version v3.23.0 installed. You must have version 3.23.1 or above."
}
andrercm commented 1 year ago

This was fixed with the PR above, closing it for now.