search

ibm-mas / ansible-devops

Ansible collection supporting devops for IBM Maximo Application Suite
https://ibm-mas.github.io/ansible-devops/
Eclipse Public License 2.0
49 stars 87 forks source link

make mas_app_cfg_delay configurable for Manage/Health #923

Closed caolan-ibm closed 1 year ago

caolan-ibm commented 1 year ago

Hi,

Can we use two new envs to make the mas_app_cfg_delay and configurable, currently it is hardcoded for different applications like: https://github.com/ibm-mas/ansible-devops/blob/6d12197a14f1fac98144446ff444233e5b243f9c/ibm/mas_devops/roles/suite_app_config/vars/health.yml

andrercm commented 1 year ago

I guess we could make these two vars capable of receiving a value from a var and keep a different suggested defaulted value for each app as in:

mas_app_cfg_retries: "{{ lookup('env', 'MAS_APP_CFG_RETRIES') | default(50, true)}}"
mas_app_cfg_delay: "{{ lookup('env', 'MAS_APP_CFG_DELAY') | default(480, true)}}"

So if these vars are not set, then it will use the default values same as it happens today, although if you do export these values and you're installing more than one application in a single run, then likely they would share the variable values while installing these apps.

@alequint @durera any thoughts about the proposed enhancement?

andrercm commented 1 year ago

Fixed by the PR https://github.com/ibm-mas/ansible-devops/pull/966