search

ibm-messaging / event-streams-samples

Apache License 2.0
95 stars 168 forks source link

Add spring examples to readme #52

Closed gfoster1 closed 4 years ago

gfoster1 commented 5 years ago
JunliWang commented 5 years ago

@gfoster1 Your change in this repo looks good, but I want to request a few changes to the tutorial: https://developer.ibm.com/tutorials/use-spring-kafka-to-access-an-event-streams-service/

  1. in the section: Create an Event Streams instance on IBM Cloud
    • Select Event Stream. -> Select Event Streams.
    • The default settings are fine for this tutorial. There is no default settings, user needs to choose a region and a plan from Lite,Standard,Enterprise. For this simple demo app, Lite plan seems to be a good fit. But we could point user to the doc about how to choose the plan: https://cloud.ibm.com/docs/services/EventStreams?topic=eventstreams-plan_choose
    • replace the screenshot with a new UI, Lite/Standard/Enterprise plans are using new UI, Classic Plan is using legacy UI and it will become inactive in Nov. and sunset in June,2020. We do not want user to use Classic plan any more.
  2. in the section: Configure Spring Boot to talk to Event Streams
    • in the code snippet of #Connection:
      spring.kafka.bootstrap-servers=kafka01-prod02.messagehub.services.us-south.bluemix.net:9093 -> spring.kafka.bootstrap-servers=<kafka_brokers_sasl>
JunliWang commented 5 years ago

@mimaison @edoardocomar want to take another look?

gfoster1 commented 5 years ago

Code review changes made on the tutorial as well as on the current code branch. Awaiting review for merge. :) @mimaison mimaison

mimaison commented 5 years ago

Thanks @gfoster1 for the updates. There are still a few spurious changes with copyright headers. I'll be happy to merge this PR once they are fixed.

mimaison commented 4 years ago

@gfoster1 Thanks for the PR! I've added a few cleanups and merged your changes