search

ibm-messaging / kafka-connect-mq-sink

This repository contains a Kafka Connect sink connector for copying data from Apache Kafka into IBM MQ.
Apache License 2.0
35 stars 43 forks source link

Allow creating new Builders using BaseMessageBuilder #21

Closed bltavares closed 5 years ago

bltavares commented 5 years ago

The current BaseMessageBuilder interface defines some abstract methods, without declaring their visibility.

This means it is by default, they are package-private, and we can't create sub-classes extending the behavior.

One scenario where extending from another package is ideal would be when extra headers are required to be sent to MQ. This commit changes the modifier to be public so others could extend them.

Similar to https://github.com/ibm-messaging/kafka-connect-mq-source/pull/26

AndrewJSchofield commented 5 years ago

This looks like a useful change. I'll take a look when I get some free time.

bltavares commented 5 years ago

I've updated the PR to only change the method signature.

I accept the CLA