search

ibm-messaging / kafka-connect-mq-source

This repository contains a Kafka Connect source connector for copying data from IBM MQ into Apache Kafka.
Apache License 2.0
95 stars 83 forks source link

fix: update deprecated set-env and update java version. #104

Closed Joel-hanson closed 1 year ago

Joel-hanson commented 1 year ago

My last github action run can be considered as an example for this change. https://github.com/Joel-hanson/kafka-connect-mq-source/actions/runs/4373115674

image

Joel-hanson commented 1 year ago

Thanks for review @dalelane

The build that I have provided in the PR is intended to demonstrate that the builds are functioning as intended and that the release is successful.

Definitely, we must manually update the versions prior to a release. I am aware that this is not a complete automation of release, since it merely uploads the jar files and sets the commit message in the release.

I believe that the release would include updating the version in each file that contains it. My understanding of a release would be as follows. Please correct me if I am wrong.

  1. Update version in the pom file mvn versions:set -DnewVersion=NEW_VERSION
  2. Update kafka-connect-mq-source jar version in Dockerfile
  3. Update versions specified in the README.md file
  4. Update the version specified in the src/main/java/com/ibm/eventstreams/connect/mqsource/MQSourceConnector.java file
  5. After making all the changes we should do a git tag and push. git tag <tagname> && git push origin <tagname>, Thus running the github actions to make a release.
dalelane commented 1 year ago

ah, I see - sorry, my misunderstanding - I had assumed that this was something that would run automatically on approved pull requests. I'd missed the point that this was an action we invoke manually when we are ready to release.