ibm-messaging / mq-asyncapi-java-template

This repository is no longer used and the project is now hosted within the ASyncAPI organisation.
https://github.com/asyncapi/java-template
Apache License 2.0
5 stars 1 forks source link

Allow credential to be provided by env vars #20

Closed dan-r closed 3 years ago

dan-r commented 3 years ago

It is generally bad practice to provide credentials in command parameters, so this change allows them to be provided in env variables.

lewis-relph commented 3 years ago

@dan-r changes look good to me, might be worth you/someone reviewing the tests before merging.

dan-r commented 3 years ago

All working but not merging yet as tests not up to date.