search

ibm-messaging / mq-dev-badge-sample

Sample code of the MQ developer essentials badge
Apache License 2.0
13 stars 37 forks source link

Ensure compatibility with Windows #14

Closed chughts closed 2 years ago

chughts commented 2 years ago

Ensure the sample runs on Windows as well as Linux and MacOS.

chughts commented 2 years ago

Something for you @Tanmay-Kudchadkar ?

dernoun commented 2 years ago

@chughts The docker file contain only commands for Linux system, I was not able to run it on windows, might I miss something ?

chughts commented 2 years ago

@dernoun The docker container is Linux / X86, but this should run on Docker on Windows / X86.

The windows issue is due to the use of symbolic links to the source files, which were introduced to reuse code without having to make duplicate copies. Windows doesn't handle the symbolic links well.

As the docker file is now making use of maven to build the application, I think the code should just be moved to where maven is expecting to find it, and removed from its original directory structure. I think this is the task for @Tanmay-Kudchadkar

chughts commented 2 years ago

This should be fixed in #20

haegray commented 2 years ago

Hello,

I tried running the code on Docker and it initially runs but then crashes saying it cannot find or load the main class. I'm working on Windows 10

chughts commented 2 years ago

It looks like the windows symbolic link fix isn't working. I will double check that there isn't any documentation that refers to the old location, and permanently move the code instead.

chughts commented 2 years ago

Fixed in #22