ibm-messaging / mq-dev-patterns

Code samples and messaging patterns for IBM MQ developers
Apache License 2.0
191 stars 165 forks source link

Modularised code into packages/crates #160

Closed supplanter-wood closed 1 year ago

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

chughts commented 1 year ago

I've asked @ibmmqmet to review.

@supplanter-wood Could you please read and sign the CLA.

ibmmqmet commented 1 year ago

Need to fix compile warnings in Delete program

warning: unused import: `std::io`
 --> src/file.rs:4:5
  |
4 | use std::io;
  |     ^^^^^^^
  |
ibmmqmet commented 1 year ago

Trying to work out what the point of this is. There's no description as to why there is such a large change with everything being split into separate files. It's making it a lot harder to read and work through what is meant to be a trivial example.

supplanter-wood commented 1 year ago

It was an attempt to tidy up the code, however I understand from an example point of view it is beneficial to keep all the code within one file.