ibmmqmet
commented
5 years ago In terms of the Java itself, there's one minor problem showing up in sendATextMessage(). The "producer" parameter to the function is either not needed or should be called something else as it gets reset in the function. I might also rewrite the userInterface() function so you don't call exit from the case statement but from outside (Eclipse shows a warning about there being no "break" statement in the case block which is understandable but I'd prefer to remove warnings where possible.)
But from a more general perspective, several things came to mind:
- The code should probably be in a subdirectory rather than in the root of the repository. We;ve talked about having language-specific trees, so perhaps under ./java/messageListener or ./jms/messageListener
- There ought to be a README describing what the program is and how to run it (even if it's going to be documented more fully elsewhere - a few lines should be there)
- similarly, a Makefile or other script to build the program and show how to run it. Especially since it builds on the MQ classes. Perhaps a pom.xml and script to drive it, so it pulls down the client code from Maven.
- there ought to be more comments in the code to describe the program. Only a line or two is needed but the code should be understandable as standalone files
- I don't like having slightly different names for the two files/classes. The use of "My..." vs "MyFirst..." Should probably have one or the other consistently between the files.
- Best practice for handling JMSExceptions is to always look for a LinkedException and print that if it exists. (JMS exceptions are frequently too generic, where the provider-specific exception has the real details.)
You shouldn't assume that someone has reached this code through the learn-mq site and examples. So things in the repository ought to be sufficient in themselves, or at least point at the web page documentation for it.
maxkahan
Please have a check Mark!