search

ibm-messaging / mq-helm

Apache License 2.0
25 stars 33 forks source link

Add Sample using Rancher RKE2 and OpenEBS #50

Closed lorellalou closed 10 months ago

callumpjackson commented 10 months ago

Hi, Thanks for taking the time to create this pull-request and sorry it has taken me sometime to review. Firstly can you verify that you agree with the contribution terms available here. I think this is a great addition to the samples, so in general I am supportive, but have a few questions/updates that I have made within the pull request.

lorellalou commented 10 months ago

You are welcome ! I will read your comments and adapt the pull request accordingly. I agree with the contribution terms available here, there is a way to formally accept it ? or my comment is enough ?

callumpjackson commented 10 months ago

Thanks - your comment in this pull request is adequate for accepting the contribution terms.

lorellalou commented 10 months ago

@callumpjackson I let you review my changes according to your comments. I have added the Native HA with 3 pods but since there is a Pod AntiAffinity in the chart we have to create a 3 nodes RKE2 cluster. To be able to test on a single node RKE2 cluster, I have removed this Pod AntiAnffinity manually.