search

ibm-messaging / mq-helm

Apache License 2.0
25 stars 33 forks source link

Support custom IP addresses in load balancer service #75

Closed htaunay closed 4 months ago

htaunay commented 5 months ago

On one hand the spec.loadBalancerIP field is being deprecated, but on the other its been over two years since it was marked as deprecated without any concrete plans to actually drop it. Its seems to be more of a warning.

In the meanwhile, some cloud providers give access to a similar functionality through annotations (e.g. Azure) while others still rely on the deprecated field (e.g. GCP).

In order to allow custom IP addresses for LoadBalancers, this MR adds an optional config to enable said behaviour (without needing to do any kubectl patchs after installing the chart). If undefined k8s will just pick a random available address from the LoadBalancer's subnet.

callumpjackson commented 5 months ago

Hi Henrique - thanks for raising the pull request. This issue was previously discussed here. The conclusion at the time was to leave this out of the Helm chart, as users can always fork the repository and make the corresponding change. Although I understand the debate I'm still apprehensive of including a field which is deprecated.

htaunay commented 4 months ago

I understand @callumpjackson , I'll close the PR and follow the fork path, thanks for the reply