ibm-openbmc / dev

Product Development Project Mgmt and Tracking
16 stars 2 forks source link

VPD: Redfish: TPM #2123

Closed gtmills closed 1 year ago

gtmills commented 4 years ago

Have VPD for TPM.

TPMenable is tracked by https://github.com/ibm-openbmc/dev/issues/1829

As part of ComputerSystem today is TrustedModules but it doesn't have a place for VPD. Could model as a "Chassis". TPM also has an LED. @vishwabmc to ask Redfish

<link to asking Redfish>

From https://redfish.dmtf.org/schemas/v1/ComputerSystem.v1_10_0.json

        "TrustedModules": {
            "additionalProperties": false,
            "description": "The Trusted Module installed in the system.",
            "longDescription": "This type shall describe a Trusted Module for a system.",
            "patternProperties": {
                "^([a-zA-Z_][a-zA-Z0-9_]*)?@(odata|Redfish|Message)\\.[a-zA-Z_][a-zA-Z0-9_]*$": {
                    "description": "This property shall specify a valid odata or Redfish property.",
                    "type": [
                        "array",
                        "boolean",
                        "integer",
                        "number",
                        "null",
                        "object",
                        "string"
                    ]
                }
            },
            "properties": {
                "FirmwareVersion": {
                    "description": "The firmware version of this Trusted Module.",
                    "longDescription": "This property shall contain the firwmare version as defined by the manufacturer for the Trusted Module.",
                    "readonly": true,
                    "type": [
                        "string",
                        "null"
                    ],
                    "versionAdded": "v1_1_0"
                },
                "FirmwareVersion2": {
                    "description": "The second firmware version of this Trusted Module, if applicable.",
                    "longDescription": "This property shall contain the 2nd firmware version, if applicable, as defined by the manufacturer for the Trusted Module.",
                    "readonly": true,
                    "type": [
                        "string",
                        "null"
                    ],
                    "versionAdded": "v1_3_0"
                },
                "InterfaceType": {
                    "anyOf": [
                        {
                            "$ref": "#/definitions/InterfaceType"
                        },
                        {
                            "type": "null"
                        }
                    ],
                    "description": "The interface type of the Trusted Module.",
                    "longDescription": "This property shall contain the interface type of the installed Trusted Module.",
                    "readonly": true,
                    "versionAdded": "v1_1_0"
                },
                "InterfaceTypeSelection": {
                    "anyOf": [
                        {
                            "$ref": "#/definitions/InterfaceTypeSelection"
                        },
                        {
                            "type": "null"
                        }
                    ],
                    "description": "The interface type selection supported by this Trusted Module.",
                    "longDescription": "This property shall contain the interface type Selection method (for example to switch between TPM1_2 and TPM2_0) that is supported by this TrustedModule.",
                    "readonly": true,
                    "versionAdded": "v1_3_0"
                },
                "Oem": {
                    "$ref": "http://redfish.dmtf.org/schemas/v1/Resource.json#/definitions/Oem",
                    "description": "The OEM extension property.",
                    "longDescription": "This property shall contain the OEM extensions.  All values for properties contained in this object shall conform to the Redfish Specification-described requirements.",
                    "versionAdded": "v1_1_0"
                },
                "Status": {
                    "$ref": "http://redfish.dmtf.org/schemas/v1/Resource.json#/definitions/Status",
                    "description": "The status and health of the Resource and its subordinate or dependent Resources.",
                    "longDescription": "This property shall contain any status or health properties of the Resource.",
                    "versionAdded": "v1_1_0"
                }
            },
            "type": "object"
santoshpuranik commented 3 years ago

Resolved by: https://gerrit.openbmc-project.xyz/c/openbmc/bmcweb/+/39574

mzipse commented 1 year ago

Closing. Work is complete.