ibm-openbmc / dev

Product Development Project Mgmt and Tracking
16 stars 2 forks source link

Thermal Metrics / Temperatures #2797

Open gtmills opened 3 years ago

gtmills commented 3 years ago

Part of the new Power / Thermal

gtmills commented 3 years ago

implement this schema: https://redfish.dmtf.org/schemas/v1/ThermalMetrics.v1_0_0.json

ChicagoDuan commented 3 years ago

Hi @gtmills, There's some questions. Please see the example response about TemperatureSummaryCelsiussuch in ThermalMetricsschema . how do we know the sensor name of Internal, It is different in different machines, may be it is "CPU1_Temp" or "cpu1Temp". So how do we hardcode the DataSourceUri? Thanks.

"@odata.type": "#ThermalMetrics.v1_0_0.ThermalMetrics",
"Id": "ThermalMetrics",
"Name": "Chassis Thermal Metrics",
"TemperatureSummaryCelsius": {
    "Internal": {
        "Reading": 39,
        "DataSourceUri": "/redfish/v1/Chassis/1U/Sensors/CPU1Temp"
},
    "Intake": {
        "Reading": 24.8,
        "DataSourceUri": "/redfish/v1/Chassis/1U/Sensors/IntakeTemp"
},
    "Ambient": {
        "Reading": 22.5,
        "DataSourceUri": "/redfish/v1/Chassis/1U/Sensors/AmbientTemp"
},
    "Exhaust": {
        "Reading": 40.5,
        "DataSourceUri": "/redfish/v1/Chassis/1U/Sensors/ExhaustTemp"
}
},
gtmills commented 3 years ago

@ChicagoDuan I think we need to discuss this with the community; we need some way to say "this is an Internal temperatureSummary sensor" or "this is an Exhaust temperatureSummarysensor" ? Maybe associations?

zhanghch05 commented 3 years ago

review: https://gerrit.openbmc-project.xyz/c/openbmc/bmcweb/+/41121

gtmills commented 2 years ago

Can we pull this one in downstream?

lxwinspur commented 2 years ago

Can we pull this one in downstream?

Sure, will do

lxwinspur commented 2 years ago

Can we pull this one in downstream?

I checked this patch and it was pulled downstream four weeks ago. https://github.com/ibm-openbmc/bmcweb/commit/aaba73ca1081d82956838220993370673dc88ac1

gtmills commented 2 years ago

Cool. Thanks! We use "Code Review in Driver" to mean it is downstream.

gtmills commented 9 months ago

Still need https://gerrit.openbmc.org/c/openbmc/bmcweb/+/41121

lxwinspur commented 8 months ago

Still need https://gerrit.openbmc.org/c/openbmc/bmcweb/+/41121

Updated