Support for OEM Systems

geissonator commented 3 years ago

When partners wish to build a system based on IBM hardware, we need to ensure we provide a mechanism for them to do this. For example, they'll want a way to put their own logo in the web interface.

Some other things to consider:

A custom hostname
A different IPMI IANA number
Other minor web interface customizations

The direction for P10 is to have a field in the VPD which will indicate the type of system. We'll use a service like that in https://github.com/ibm-openbmc/openbmc/commit/69ae2e079a8643ace8cf1d44988174cc8f2cf8a9 to ensure the correct logo is loaded.

geissonator commented 3 years ago

FYI @gtmills

geissonator commented 2 years ago

This story will track the following:

Enhance https://github.com/ibm-openbmc/openbmc/commit/69ae2e079a8643ace8cf1d44988174cc8f2cf8a9 to support p10bmc systems. It must support:
- IBM Systems
- IPS Systems
- OEM Systems

Need details from @santoshpuranik (?) on what VPD keyword will be used for this and what the different possible values are.

A custom hostname should not be needed as the default is just "p10bmc" now which should be fine for all system types.

I'm not sure if a different IPMI IANA number is needed or not.

gtmills commented 2 years ago

We should follow the design in https://github.com/ibm-openbmc/openbmc/commit/69ae2e079a8643ace8cf1d44988174cc8f2cf8a9 No changes to the GUI or bmcweb needed here

geissonator commented 2 years ago

ok, so as Gunnar mentioned, this is going to look at lot like https://github.com/ibm-openbmc/openbmc/commit/69ae2e079a8643ace8cf1d44988174cc8f2cf8a9

The work:

@kennyneedsmilky is working on a change to the GUI code to make the logo file names generic (they were switched to something more IBM specific in vue). Once he has that, we'll update this issue with new file names.
The files to override are in /usr/share/www/img/ on eBMC p10bmc images
Instead of using the Model, we're going to use the Brand. To get the Brand in your script, use the following:
```
busctl get-property xyz.openbmc_project.Inventory.Manager /xyz/openbmc_project/inventory/system xyz.openbmc_project.Inventory.Decorator.Asset SubModel
```
S0 || D0 = IBM J0 = IPS (need IPS to confirm this) ANYTHING ELSE = OEM

All of this should be built into the p10bmc image so it will support all 3 Brands in a single image.

geissonator commented 2 years ago

The needed GUI change is merged up at https://github.com/ibm-openbmc/webui-vue/commit/924cd305f79c1a51bf67a5cf15954397e0aefdf6

lxwinspur commented 2 years ago

@geissonator @mzipse Review by: https://github.com/ibm-openbmc/openbmc/pull/231

geissonator commented 2 years ago

Put in under https://github.com/ibm-openbmc/openbmc/pull/233

ghost commented 2 years ago

ok, so as Gunnar mentioned, this is going to look at lot like ibm-openbmc/openbmc@69ae2e0

The work:

@kennyneedsmilky is working on a change to the GUI code to make the logo file names generic (they were switched to something more IBM specific in vue). Once he has that, we'll update this issue with new file names.

The files to override are in /usr/share/www/img/ on eBMC p10bmc images

Instead of using the Model, we're going to use the Brand. To get the Brand in your script, use the following:
busctl get-property xyz.openbmc_project.Inventory.Manager /xyz/openbmc_project/inventory/system xyz.openbmc_project.Inventory.Decorator.Asset SubModel
S0 || D0 = IBM J0 = IPS (need IPS to confirm this) ANYTHING ELSE = OEM

All of this should be built into the p10bmc image so it will support all 3 Brands in a single image.

Handle now changed to @kennyfully88 . Sorry for the confusion

ibm-openbmc / dev

Support for OEM Systems #2895