ibm-openbmc / dev

Product Development Project Mgmt and Tracking
16 stars 2 forks source link

PFP::control: Extraneous mapper lookups occur down the `addGroups()` path #3509

Closed msbarth closed 2 years ago

msbarth commented 2 years ago

Need to determine where a "leak" of mapper lookups is occurring down the addGroups() path for doing bulk reads of sensors from dbus.

*Note: Providing the service for each group entirely eliminates the mapper lookups so this is needed for when group members may be provided by more than one service and the service has to be looked up for each member.

msbarth commented 2 years ago

Its been determined that the "leak" of mapper lookups is due to the number of object paths that do not exist on dbus for sensors that may not exist due to a system's specific sensor configuration. Fan control is configured to handle a full system config, but partial configs will not expose some sensor object paths to dbus and therefore never exist on dbus. Due to this, fan control continually attempts to retrieve those sensors since it doesnt know if/when it would ever show up or not onto dbus.

So the current ability to handle this is to correctly configure the groups of sensors within groups.json so that the service providing all the group member's object paths (and associated configured interface in events.json) is predetermined and the lookups can be skipped regardless of whether or not the sensor is actually on dbus.