ibm-openbmc / dev

Product Development Project Mgmt and Tracking
16 stars 2 forks source link

PCIe Topology: Redfish: Link Status #3552

Closed gtmills closed 2 years ago

gtmills commented 2 years ago

See https://github.ibm.com/gmills/pcie-topology

            if device_in_slot.status.state == "Enabled" and \
                    device_in_slot.status.health == "OK":
                row["Link Status"] = "operational"
            elif device_in_slot.status.state == "Enabled" and \
                    device_in_slot.status.health != "OK":
                row["Link Status"] = "degraded"
            elif device_in_slot.status.state == "Disabled":
                row["Link Status"] = "deactivated"
            elif device_in_slot.status.state == "UnavailableOffline":
                row["Link Status"] = "failed"
            elif device_in_slot.status.state == "StandbyOffline":
                row["Link Status"] = "inactive"

Should do here: https://github.com/ibm-openbmc/bmcweb/blob/1020/redfish-core/lib/pcie_slots.hpp Downstream only since the PDI is

gtmills commented 2 years ago

https://github.com/ibm-openbmc/phosphor-dbus-interfaces/pull/52/files

gtmills commented 2 years ago

Actually, moving to code review in driver since we should still do this upstream

mzipse commented 2 years ago

Work is complete. Closing.