search

ibm-openbmc / dev

Product Development Project Mgmt and Tracking
16 stars 2 forks source link

Upstream ChangeLogo / bbappend file failed to load sensor yaml #3632

Open gtmills opened 1 year ago

gtmills commented 1 year ago

Would be great if commits: https://github.com/ibm-openbmc/openbmc/pull/285 and https://github.com/ibm-openbmc/openbmc/pull/284 could go upstream. Would have to upstream the entire changeLogo stuff.

Thanks for all the help!

lxwinspur commented 1 year ago

Sure @gtmills Will do

lxwinspur commented 1 year ago

@gtmills https://github.com/ibm-openbmc/openbmc/pull/285 is already the latest upstream. https://github.com/openbmc/openbmc/blob/master/meta-ibm/recipes-phosphor/ipmi/phosphor-ipmi-host_%25.bbappend

lxwinspur commented 1 year ago

For https://github.com/ibm-openbmc/openbmc/pull/284 IBM did not upstream this feature.

gtmills commented 1 year ago

For https://github.com/ibm-openbmc/openbmc/pull/284 IBM did not upstream this feature.

@lxwinspur can IPS help us here by upstreaming ?

lxwinspur commented 1 year ago

Review by: https://gerrit.openbmc.org/c/openbmc/openbmc/+/66406

gtmills commented 1 year ago

Review by: https://gerrit.openbmc.org/c/openbmc/openbmc/+/66406

Thanks! The community had a strong reaction to this.. I wonder if IPS could create an env.ips similar to https://github.com/ibm-openbmc/webui-vue/blob/1050/.env.ibm and set the logo there and do their other webui-vue changes ? And then in a bbappend that could be set to --mode ips

gtmills commented 11 months ago

Still a valid issue