search

ibm-openbmc / openbmc

https://github.com
Other
19 stars 51 forks source link

Add org/freedesktop #258

Closed lxwinspur closed 1 year ago

lxwinspur commented 1 year ago

IBM enbale org/freedesktop by default, otherwise the compilation image will fail because PDI cannot be found.

Signed-off-by: George Liu liuxiwei@inspur.com

lxwinspur commented 1 year ago

@RameshIyyar @anoo1 @gtmills Please review it.

jenkins-openbmc-ibm commented 1 year ago

Can one of the admins verify this patch?

smccarney commented 1 year ago

I was actually debugging the same problem myself and had discovered the need to modify the OBMC_ORG_YAML_SUBDIRS value in the IBM recipe. Looks like you fixed it first. Great!

@geissonator recommended putting the same change in upstream. That way a downstream-only commit is not needed long term. Do you mind putting the same change upstream?

smccarney commented 1 year ago

I am going to test this PR/change myself to verify it resolves the problem I was debugging.

lxwinspur commented 1 year ago

@smccarney I pushed a new commit upstream, please review it: https://gerrit.openbmc.org/c/openbmc/openbmc/+/60246

smccarney commented 1 year ago

@smccarney I pushed a new commit upstream, please review it: https://gerrit.openbmc.org/c/openbmc/openbmc/+/60246

Done.

Thanks for making this change in both places. Great job.

smccarney commented 1 year ago

The upstream change has been merged. Not sure if the PR is still needed?

rfrandse commented 1 year ago

This change was pulled into 1050.00 with this commit https://github.com/ibm-openbmc/openbmc/commit/868333a44a1b8d29aa3a3d7bd250c41e64b37c48